ocamlPackages.camlp5: 7.07 -> 7.08 #66212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
binaries seem to work
[29 built, 72 copied (1571.9 MiB), 315.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66212
16 package were build:
compcert coqPackages.contribs.aac-tactics coqPackages.contribs.containers coqPackages.contribs.zfc coqPackages.contribs.zorns-lemma coq_8_10 coq_8_5 coq_8_6 coq_8_7 coq_8_8 coq_8_9 framac hol_light prooftree satallax why3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Compatibility with OCaml 4.08
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)