Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cocoapods-beta: 1.7.5 -> 1.8.0.beta.1 #66251

Merged
merged 1 commit into from Aug 17, 2019
Merged

cocoapods-beta: 1.7.5 -> 1.8.0.beta.1 #66251

merged 1 commit into from Aug 17, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Aug 7, 2019

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.8.0.beta.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lilyball lilyball mentioned this pull request Aug 8, 2019
Open
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/45

@aanderse
Copy link
Member

aanderse commented Aug 17, 2019 •
edited

@GrahamcOfBorg build cocoapods-beta

@lilyball thanks!

@lilyball
Copy link
Member Author

@aanderse this PR only updates cocoapods-beta, not cocoapods.

aanderse
aanderse approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging based on the good word of @lilyball. Thanks for your continued awesome work! 🎉

@aanderse aanderse merged commit a2bd8da into NixOS:master Aug 17, 2019
@lilyball
Copy link
Member Author

Thanks!

@lilyball lilyball deleted the cocoapods-beta branch August 17, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @nixos-discourse @aanderse