Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/jenkins: Copy plugins as .jpi instead of .hpi #66124

Merged
merged 1 commit into from Sep 17, 2019
Merged

nixos/jenkins: Copy plugins as .jpi instead of .hpi #66124

merged 1 commit into from Sep 17, 2019

Conversation

WhittlesJr
Copy link
Contributor

Motivation for this change

Resolves #65580

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WhittlesJr
Copy link
Contributor Author

Er, sorry, I had the wrong committer metadata on that. I'll fix that tomorrow.

@WhittlesJr
Copy link
Contributor Author

All better

@WhittlesJr
Copy link
Contributor Author

@coreyoconnor says this is safe. Should I notify anyone else to get this under review?

@coreyoconnor
Copy link
Contributor

For the record: the reason this is safe is because jenkins normalizes plugins to .jpi anyways. .hpi is deprecated and only supported for hudson compatibility.

I've tested this on my jenkins instance without issue.

@WhittlesJr WhittlesJr force-pushed the jenkins-jpi branch 3 times, most recently from 9ce5b7d to f954c66 Compare September 13, 2019 17:12
@bjornfor
Copy link
Contributor

Can you sum up the motivation behind this change into the commit message? (So archeologists only need the git repo and not github.)

@WhittlesJr
Copy link
Contributor Author

Alright, how's does that look?

@bjornfor bjornfor merged commit f012243 into NixOS:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jenkins plugins should be copied as .jpi
3 participants
@WhittlesJr @coreyoconnor @bjornfor