msbuild: init at 16.3 #66134
msbuild: init at 16.3 #66134
Conversation
|
I guess I did all I could at this point. I can build and run msbuild on my machine. Known issues: My checkPhase does not seem to be running, I am skipping tests during build, and I am getting a failure from the ci bot which I don't understand. |
|
Have you tried |
|
Rebased and ready for review. Only outstanding work to do is the disabled unit tests during build. Can I get it in without them? I have installCheckPhase, at least. |
|
One more issue. Jetbrains.rider does not accept the wrapped executable, it only takes the dll. But then the MSBuildExtensionsPath variable is not configured and builds fail. I can fix that in the rider gui by setting msbuild global property, but it is a hassle. |
|
Still one more MSBuildExtensionsPath thing. OmniSharp autoconfiguration does not pick it correctly either, see #43680 (comment). |
|
@jdanekrh maybe you can have an unwrapped version that is passed to rider and then you set MSBuildExtensionsPath in rider itself. |
|
@Mic92 The wrapper must be a shell script, though, right? I cannot wrap a .net dll in another dll. My problem is that Rider needs to be given a MSBuild.dll, if I give it a shell script, it screams
|
|
Sorry, I misunderstood the comment. Yes, you are absolutely right. What you said is what I am doing to make this work for me. |
| }; | ||
|
|
||
| in [ | ||
| (fetchNuGet { |
There was a problem hiding this comment.
Yes, I adapted what https://github.com/NixOS/nixpkgs/tree/master/pkgs/servers/nosql/eventstore does.
Motivation for this change
Based upon #43680 and #50842
(Sort of) fixes #29817
Depends on PRs #65875 and #66131
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @thoughtpolice @obadz @vrthra @worldofpeace @samueldr