Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnetPackages.Nuget: 3.4.3 -> 4.9.1 #66131

Closed
wants to merge 1 commit into from

Conversation

jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Aug 5, 2019

Motivation for this change

Required to build msbuild without silly workarounds to do nuget restore successfully. Packages added with older nuget add are then not found by newer nuget that is used in the msbuild build scripts.

There are newer versions of nuget, just not in the mono/nuget-binary repo from which this package was originally built. The downloads from https://www.nuget.org/downloads ran for me in mono just fine, but I did not test extensively, so I'll stick to mono/nuget-binary for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @obadz

@jirkadanek
Copy link
Member Author

This was merged as part of PR #66299 in commit a9b4e75

@jirkadanek jirkadanek closed this Aug 27, 2019
@jirkadanek jirkadanek deleted the jd_nuget branch August 27, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants