Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sam-cli: 0.16.1 -> 0.19.0 #66125

Closed
wants to merge 3 commits into from
Closed

aws-sam-cli: 0.16.1 -> 0.19.0 #66125

wants to merge 3 commits into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Saw a weird error while reviewing another pr

Actions:

  • python2 -> python3
  • version bump
  • made python2 only libs optional
  • added longDescription
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andreabedini
@FRidh because it's most a python package.

worldofpeace
worldofpeace suggested changes Aug 7, 2019
View reviewed changes
pkgs/development/tools/aws-sam-cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/aws-sam-cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/aws-sam-cli/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor Author

Rebased on top of master, and applied changes.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build aws-sam-cli

@jonringer
Copy link
Contributor Author

@worldofpeace @marsam rebased on top of master, applied changes 6 weeks ago :)

@worldofpeace
Copy link
Contributor

@jonringer We'll see about integrating. And commit bit soon 🤣

@ofborg ofborg bot requested a review from dhl September 29, 2019 10:35
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build aws-sam-cli

@jonringer
Copy link
Contributor Author

jonringer commented Sep 29, 2019 •
edited

bumped and no regressions

[3 built, 1 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66125
5 package were build:
aws-sam-cli python27Packages.aws-lambda-builders python27Packages.serverlessrepo python37Packages.aws-lambda-builders python37Packages.serverlessrepo

@jonringer
Copy link
Contributor Author

master is now at 0.22.0, closing

@jonringer jonringer closed this Nov 25, 2019
@jonringer jonringer deleted the bump-aws-sam branch November 25, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@dhl dhl Awaiting requested review from dhl

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace