Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hedgewars: 0.9.25 -> 1.0.0-beta1 #66289

Merged
merged 1 commit into from Aug 8, 2019

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Aug 7, 2019

  • unbreak build by bumping version to latest beta as that
    removes the broken bytestring-show dependency

  • beta needs to be fetched from Mercurial repo

Motivation for this change

Hedgewars is currently broken due to depending on the abandoned and broken bytestring-show package.
In the latest 1.0.0 Beta 1 release that dependency has been removed.
So I figure having a working beta version in nixpkgs to be better than having a broken stable release.

Please also backport to release-19.03, I've tested it successfully on stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @kragniz

- unbreak build by bumping version to latest beta as that
removes the broken `bytestring-show` dependency

- beta needs to be fetched from Mercurial repo
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build hedgewars

Copy link
Member

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@Mic92 Mic92 merged commit 073730c into NixOS:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants