roon-server: disable DynamicUser #66291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DynamicUser currently breaks the backup functionality provided by roon, as the roon server cannot write to non-canonical directories and the recycled UIDs/GIDs would make managing permissions for the directory impossible. On top of that, it would break the ability to manage the local music library files (as it would not be able to delete them).
|
You should use a normal NixOS user declaration instead then. How it is now the service would run as |
|
Yeah I figured I need to do some sort of id declaration. adding it in now |
Adds defined IDs
infinisil
reviewed
Aug 7, 2019
|
Also, should I set |
|
Yeah I'd set |
aanderse
requested changes
Aug 7, 2019
If the user changes the user for roon, we can assume they handled the setup for it
|
There's not a specific reason for customizing it, no. It can be hard-coded. |
|
Actually, I think it would be useful at make managing permissions easier. Roon itself is usually packaged to run as root, which means it usually ignores a lot of this (and it makes some assumptions about things it can do) |
infinisil
reviewed
Aug 8, 2019
| @@ -19,6 +19,20 @@ in { | |||
| TCP: 9100 - 9200 | |||
| ''; | |||
| }; | |||
| user = mkOption { | |||
| type = types.string; | |||
There was a problem hiding this comment.
Use types.str instead. types.string is deprecated
infinisil
reviewed
Aug 9, 2019
|
Anything else I ought to clean up here? |
infinisil
approved these changes
Aug 20, 2019
|
Yeah looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
DynamicUser currently breaks the backup functionality provided by roon,
as the roon server cannot write to non-canonical directories and the
recycled UIDs/GIDs would make managing permissions for the directory
impossible. On top of that, it would break the ability to manage the
local music library files (as it would not be able to delete them).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)