Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscenegraph: drop 3.4.x #66227

Merged
merged 4 commits into from Aug 8, 2019
Merged

openscenegraph: drop 3.4.x #66227

merged 4 commits into from Aug 8, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 6, 2019 •
edited

Motivation for this change

#66149

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-review pr 66227
  • Tested execution of all some binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c - will ping you after testing is complete

@ofborg ofborg bot requested a review from 7c6f434c August 6, 2019 20:31
@aanderse aanderse marked this pull request as ready for review August 6, 2019 21:13
@aanderse
Copy link
Member Author

aanderse commented Aug 6, 2019

@7c6f434c minimal testing but I was able to load up both flightgear and speed-dreams and poke around. Doing a quick grep (~/nixpkgs> grep -inR openscenegraph_3_4 pkgs/) yielded no results, so I think this PR catches all the remaining programs which require it.

@7c6f434c
Copy link
Member

7c6f434c commented Aug 8, 2019

Nice, thanks! I would assume that if grep doesn't find references and full eval passes, the removal went fine…

@7c6f434c 7c6f434c merged commit 6b5647a into NixOS:master Aug 8, 2019
@aanderse aanderse deleted the osg-3.4 branch August 21, 2019 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @7c6f434c