Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsharp41: 4.1.7 -> 4.1.34; mono = mono6 #66299

Merged
merged 4 commits into from Aug 26, 2019
Merged

fsharp41: 4.1.7 -> 4.1.34; mono = mono6 #66299

merged 4 commits into from Aug 26, 2019

Conversation

jirkadanek
Copy link
Member

Motivation for this change

Update another consumer of mono4. Together with #66255, there should be no uses of mono4 left in the nixpkgs tree.

Depends on #66134 for msbuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @7c6f434c

7c6f434c
7c6f434c approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity that apparently there is no trivial-to-verify way to make sure that myget.org references go to the proper builds of the dependencies, but apparently this is hard to avoid.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build fsharp41

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build msbuild

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build dotnetPackages.Nuget

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build mono6

1 similar comment
@jirkadanek
Copy link
Member Author

@GrahamcOfBorg build mono6

@jirkadanek
Copy link
Member Author

mono6 on x86_64-darwin timed out for no (to me) obvious reason. wanted to try if maybe I can retrigger it unchanged. apparently not.

@mmahut
Copy link
Member

mmahut commented Aug 21, 2019

@GrahamcOfBorg build mono6

@jirkadanek
Copy link
Member Author

It ran a little bit further in https://logs.nix.ci/?attempt_id=c323e29a-bf41-4bed-8533-3226bdda8881&key=nixos%2Fnixpkgs.66299 than in https://logs.nix.ci/?attempt_id=4690cdd7-839d-4e1e-866a-843e19635f03&key=nixos%2Fnixpkgs.66299, but at the end, macos still timeouted.

@mmahut
Copy link
Member

mmahut commented Aug 21, 2019

yeah, @NixOS/darwin-maintainers anyone willing to give this a try please? :)

@obadz obadz merged commit a9b4e75 into NixOS:master Aug 26, 2019
This was referenced Aug 27, 2019
Closed
Closed
Merged
@leo60228 leo60228 mentioned this pull request Nov 11, 2019
Closed
@jraygauthier jraygauthier mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@obadz obadz Awaiting requested review from obadz

@vrthra vrthra Awaiting requested review from vrthra

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jirkadanek @mmahut @7c6f434c @obadz @jiridanek