[webnfc] Enable wpt tests with mock nfc implementation #18290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 6, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1737993
branch
7 times, most recently
from
8005344
to
5024a0f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1737993
branch
2 times, most recently
from
336c78f
to
8841059
Compare
This CL enables all failure tests from wpt/web-nfc/(except the idlharness tests) with mock NFC implementation, which automates all the manual tests at the same time. Merge NFCWriter#push() relevant tests into one file: NFCWriter_push.https.html Merge NFCReader relevant tests into two separate files: NFCReader.https.html and NFCReader_options.https.html BUG=520391 Change-Id: Iefc61b618bebcdc198dc4a2470350480b2cc2cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737993 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#687130}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1737993
branch
from
8841059
to
f5cae31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL enables all failure tests from wpt/web-nfc/(except the idlharness tests) with mock NFC
implementation, which automates all the manual tests at the same time.
Merge NFCWriter#push() relevant tests into one file: NFCWriter_push.https.html
Merge NFCReader relevant tests into two separate files: NFCReader.https.html and
NFCReader_options.https.html
BUG=520391
Change-Id: Iefc61b618bebcdc198dc4a2470350480b2cc2cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737993
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#687130}