elpi: 1.4.1 -> 1.6.0, and coq-elpi #66183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
requested changes
Aug 6, 2019
CohenCyril
force-pushed
the
coq-elpi
branch
2 times, most recently
from
bc25ebb
to
e731156
Compare
|
@GrahamcOfBorg build coqPackages_8_10.coq-elpi |
jonringer
reviewed
Aug 8, 2019
| in | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "coq${coq.coq-version}-elpi-${param.version}"; |
There was a problem hiding this comment.
not sure if this is more right, but I think this is "more correct"
Suggested change
| name = "coq${coq.coq-version}-elpi-${param.version}"; | |
| name = "coq-${coq.coq-version}-${coq.ocamlPackages.elpi.name}"; |
"coq8.10-elpi-master" as name to "coq-8.10-elpi-1.6.0"
however, since you're taking depending on a specific commit, the normal convention is
Suggested change
| name = "coq${coq.coq-version}-elpi-${param.version}"; | |
| pname = "coq-elpi"; | |
| version = "unstable-2019-08-02"; |
I don't think i've seen a package that had dependencies as part of the title.
jonringer
reviewed
Aug 8, 2019
|
|
||
| installFlags = "COQLIB=$(out)/lib/coq/${coq.coq-version}/"; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Suggested change
| meta = { | |
| meta = with stdenv.lib; { |
|
|
||
| meta = { | ||
| description = "Coq plugin embedding ELPI."; | ||
| maintainers = [ stdenv.lib.maintainers.cohencyril ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ stdenv.lib.maintainers.cohencyril ]; | |
| maintainers = with maintainers; [ cohencyril ]; |
| meta = { | ||
| description = "Coq plugin embedding ELPI."; | ||
| maintainers = [ stdenv.lib.maintainers.cohencyril ]; | ||
| license = stdenv.lib.licenses.lgpl21; |
There was a problem hiding this comment.
Suggested change
| license = stdenv.lib.licenses.lgpl21; | |
| license = licenses.lgpl21; |
| nativeBuildInputs = [ which ]; | ||
| buildInputs = [ coq coq.ocaml ] ++ (with coq.ocamlPackages; [ findlib elpi ]); | ||
|
|
||
| installFlags = "COQLIB=$(out)/lib/coq/${coq.coq-version}/"; |
There was a problem hiding this comment.
Suggested change
| installFlags = "COQLIB=$(out)/lib/coq/${coq.coq-version}/"; | |
| installFlags = "COQLIB=${placeholder "out"}/lib/coq/${coq.coq-version}/"; |
|
@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_04.elpi |
vbgl
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
update of elpi and adding compatible development version of coq-elpi
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @vbgl