Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3lock: 2.10 -> 2.12 #66180

Merged
merged 1 commit into from Aug 6, 2019
Merged

i3lock: 2.10 -> 2.12 #66180

merged 1 commit into from Aug 6, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Aug 6, 2019

Motivation for this change

CHANGELOG

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @malyn, @domenkozar

@ofborg ofborg bot requested a review from domenkozar August 6, 2019 09:23
@Ma27
Copy link
Member

Ma27 commented Aug 6, 2019

@GrahamcOfBorg build i3lock

@Ma27
Copy link
Member

Ma27 commented Aug 6, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 9621b84 into NixOS:master Aug 6, 2019
@sikmir sikmir deleted the i3lock branch August 6, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @Ma27