Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the MacOS target version to 10.12 signalled xcbuild that libcompression is available on Darwin, but libcompression is not OSS (even though an LZFSE reference implementation is), and it is not part of a framework for us to make impure, so this patch disables it.
I can't think of a way to get these deps otherwise:
compression.h
is at/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/compression.h
andlibcompression.dylib
is at/usr/lib/libcompression.dylib
Motivation for this change
Make it build again.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @copumpkin @matthewbauer