Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.nipype: 1.1.9 -> 1.2.0 #66150

Closed
wants to merge 6 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 6, 2019

Motivation for this change

noticed nibabel was broken while doing a review.

Actions:

  • bumped outdated
  • enabled as many tests i could
  • added missing dependencies
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nilearn fails due to scikit-learn broken on master. And I don't want to touch that with a 10ft pole.

[6 built (1 failed), 3 copied (30.8 MiB), 8.9 MiB DL]
error: build of '/nix/store/01s3v7971g9prd5v2zw2wiv6gjqz05p1-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66150
1 package failed to build:
python37Packages.nilearn

15 package were build:
python27Packages.bids-validator python27Packages.delegator-py python27Packages.nibabel python27Packages.nilearn python27Packages.nipy python27Packages.nipype python27Packages.num2words python27Packages.pybids python37Packages.bids-validator python37Packages.delegator-py python37Packages.nibabel python37Packages.nipy python37Packages.nipype python37Packages.num2words python37Packages.pybids

@FRidh
Copy link
Member

FRidh commented Aug 18, 2019

Thanks. Pushed to staging.

@FRidh FRidh closed this Aug 18, 2019
@jonringer jonringer deleted the fix-nipype branch August 19, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants