Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doh-proxy: 0.0.8 -> 0.0.9 #66118

Merged
merged 2 commits into from Aug 17, 2019
Merged

doh-proxy: 0.0.8 -> 0.0.9 #66118

merged 2 commits into from Aug 17, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Had a weird error while i was doing a nix-review of another pr.

Actions:

  • bumped version
  • enabled tests
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner August 5, 2019 21:08
@ofborg ofborg bot requested a review from alyssais August 5, 2019 21:24
@ofborg ofborg bot requested a review from alyssais August 7, 2019 17:28
alyssais
alyssais requested changes Aug 12, 2019
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re license: yeah, upstream really should provide a LICENSE or COPYING file. Might be an idea to open an issue?

fwiw, we can’t just assume software is free because it’s public. There has to be some indication of a free license.

pkgs/servers/dns/doh-proxy/default.nix Show resolved Hide resolved
@FRidh FRidh merged commit 5775243 into NixOS:master Aug 17, 2019
@jonringer jonringer deleted the bump-doh-proxy branch August 17, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @alyssais @FRidh