Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profanity 0.7.0 #66119

Merged
merged 2 commits into from Aug 9, 2019
Merged

Profanity 0.7.0 #66119

merged 2 commits into from Aug 9, 2019

Conversation

toon23
Copy link
Contributor

@toon23 toon23 commented Aug 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

aanderse commented Aug 7, 2019 •
edited

@GrahamcOfBorg build profanity

@aanderse
Copy link
Member

aanderse commented Aug 7, 2019

@marsam If @toon23 rebases on the latest master (see #66154) will profanity build on darwin?

../Libraries/libcar/Sources/Rendition.cpp:29:10: fatal error: 'compression.h' file not found
#include <compression.h>

@toon23
Copy link
Contributor Author

toon23 commented Aug 8, 2019

@aanderse: I've rebased the branch to current master.

aanderse
aanderse requested changes Aug 8, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... sorry, just noticed the commit messages. Please change messages to be:

  • profanity: 0.6.0 -> 0.7.0
  • profanity: Add optional omemo support (enabled by default)

@toon23
Copy link
Contributor Author

toon23 commented Aug 9, 2019

@aanderse: I changed the commit messages. Thank you for your patience. 😃

@aanderse aanderse merged commit 3f441e1 into NixOS:master Aug 9, 2019
@aanderse
Copy link
Member

aanderse commented Aug 9, 2019

No problem at all. Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toon23 @aanderse @Janik-Haag