ISSUE-21803: Implement ConstantSourceNode audionode #23919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
jdm
requested changes
Aug 9, 2019
| @@ -1,5 +1,4 @@ | |||
| [constant-source-basic.html] | |||
| expected: ERROR | |||
| [X Factory method: node = context.createConstantSource() incorrectly threw TypeError: "context.createConstantSource is not a function".] | |||
There was a problem hiding this comment.
I believe this whole file can be deleted now.
| @@ -1,5 +1,4 @@ | |||
| [ctor-constantsource.html] | |||
| expected: ERROR | |||
| [X node0 = new ConstantSourceNode(context) incorrectly threw TypeError: "window[name\] is not a constructor".] | |||
jdm
added
S-needs-squash
highfive
added
the
S-awaiting-review
|
OK @jdm, done! |
|
@bors-servo r+ |
|
📌 Commit b0a5d02 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 10, 2019
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
highfive
added
S-tests-failed
|
Surprising new failures: Delightful new passes: Test that needs to be updated to include the new interface: |
highfive
added
the
S-awaiting-review
|
@jdm wanted to be able to quickly undo the test metadata changes in case I misunderstood the request, so I have not squashed into one commit yet. Mind quickly confirming that this is fine? If so I'll also go ahead and file the follow-up issue outlining the relevant tests that now fail. |
|
@bors-servo try=wpt |
bors-servo
pushed a commit
that referenced
this pull request
Aug 12, 2019
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
The test expectations changes look good to me. You can go ahead and squash the commits and file the follow-up issue. Thanks! |
|
@bors-servo r+ |
|
📌 Commit 6027dd1 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 15, 2019
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
|
@bors-servo retry |
|
💣 Failed to start rebuilding: |
bors-servo
pushed a commit
that referenced
this pull request
Aug 15, 2019
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less followed the steps outlined in
components/script/dom/mod.rs(and also used the previous PR on this issue as reference). Updatedwpttests as well../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is