Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jsonschema: 2.6.0 -> 3.0.2 #66312

Closed
wants to merge 1 commit into from
Closed

pythonPackages.jsonschema: 2.6.0 -> 3.0.2 #66312

wants to merge 1 commit into from

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Aug 8, 2019

Motivation for this change

Update jsonschema to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar

@jbaum98 jbaum98 requested a review from FRidh as a code owner August 8, 2019 04:10
@ofborg ofborg bot requested a review from domenkozar August 8, 2019 04:22
@jonringer
Copy link
Contributor

this breaks around 40 packages, I would hold off for a while until downstream packages have time to bump.

@worldofpeace
Copy link
Contributor

Didn't @costrouc already do this and it got merged to python-unstable with other things?

@FRidh You never did explain to me the situation with python-unstable, because I recall when the topic came up of updating this you said we should use that branch.

@FRidh
Copy link
Member

FRidh commented Aug 9, 2019

I use python-unstable to check typically selections of commits and force push to that branch.

@FRidh
Copy link
Member

FRidh commented Aug 9, 2019

This is a duplicate.

@FRidh FRidh closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbaum98 @jonringer @worldofpeace @FRidh