Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bugwarrior: depend on jira, remove unused test deps #66234

Merged
merged 1 commit into from Jan 7, 2020
Merged

pythonPackages.bugwarrior: depend on jira, remove unused test deps #66234

merged 1 commit into from Jan 7, 2020

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Aug 6, 2019 •
edited

Motivation for this change
  • Add Jira support
  • Comment out unused test dependencies
  • Drop Python 2.7 support, per upstream
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq yurrriq requested a review from FRidh as a code owner August 6, 2019 21:52
@ofborg ofborg bot requested a review from nbp August 6, 2019 22:07
@yurrriq
Copy link
Member Author

yurrriq commented Aug 6, 2019

@GrahamcOfBorg build python35Packages.bugwarrior python37Packages.bugwarrior

@yurrriq
Copy link
Member Author

yurrriq commented Oct 23, 2019

Anything blocking merging this? /ping @FRidh

@yurrriq
Copy link
Member Author

yurrriq commented Nov 2, 2019

/ping @Mic92, any chance you can help me out here too? 😇

@yurrriq
Copy link
Member Author

yurrriq commented Dec 19, 2019

any update on this?

@yurrriq
Copy link
Member Author

yurrriq commented Dec 22, 2019

@GrahamcOfBorg build python36Packages.bugwarrior python37Packages.bugwarrior

jonringer
jonringer reviewed Dec 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits

git reset HEAD~5
git add pkgs/
git commit -m "pythonPackages.bugwarrior: depend on jira, comment out test deps"
git push <fork> <branch> --force

pkgs/development/python-modules/bugwarrior/default.nix Outdated Show resolved Hide resolved
@yurrriq
Copy link
Member Author

yurrriq commented Dec 23, 2019

I can't (be bothered to) get it to build for pythonOlder "3.8" now, so I've updated disabled accordingly.

@yurrriq
Copy link
Member Author

yurrriq commented Dec 23, 2019

@GrahamcOfBorg build python38Packages.bugwarrior

@yurrriq yurrriq changed the title pythonPackages.bugwarrior: depend on jira, comment out test deps pythonPackages.bugwarrior: depend on jira, remove unused test deps Dec 23, 2019
@jonringer
Copy link
Contributor

we're doing a large update to the the python ecosystem in #76059, please just hold on a bit, it will make your other python versions much easier to package

@yurrriq
Copy link
Member Author

yurrriq commented Dec 30, 2019

There's a problem with taskw -> tox -> importlib-metadata on python 3.5-3.7.

@jonringer
Copy link
Contributor

python-unstable was merged into staging next, once #76705 gets merged, this shouldn't be an issue

@FRidh FRidh changed the base branch from master to staging-next December 30, 2019 21:59
@FRidh FRidh changed the base branch from staging-next to master December 30, 2019 21:59
@yurrriq
Copy link
Member Author

yurrriq commented Jan 7, 2020

Hmm.. after rebasing on #76705, this doesn't work anymore. Any tips? I'm not much into Python these days.

ModuleNotFoundError: No module named 'pkg_resources'

@yurrriq yurrriq changed the title pythonPackages.bugwarrior: depend on jira, remove unused test deps WIP: pythonPackages.bugwarrior: depend on jira, remove unused test deps Jan 7, 2020
@yurrriq
pythonPackages.bugwarrior: depend on jira, remove test deps
703adfe 
- drop support for 2.7, per upstream
- remove half-baked checkInputs, but leave comment
- add yurrriq as maintainer
- add setuptools to propagatedBuildInputs
@yurrriq yurrriq changed the title WIP: pythonPackages.bugwarrior: depend on jira, remove unused test deps pythonPackages.bugwarrior: depend on jira, remove unused test deps Jan 7, 2020
@yurrriq
Copy link
Member Author

yurrriq commented Jan 7, 2020

All good with setuptools now.

jonringer
jonringer approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[4 built, 63 copied (40.1 MiB), 8.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66234
2 package built:
python37Packages.bugwarrior python38Packages.bugwarrior

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.bugwarrior python38Packages.bugwarrior

@jonringer jonringer merged commit 826df23 into NixOS:master Jan 7, 2020
@jonringer jonringer added this to Done in Python 2 deprecation via automation Jan 7, 2020
@yurrriq
Copy link
Member Author

yurrriq commented Jan 7, 2020

🎉 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurrriq @jonringer @FRidh