mixxx: drop custom wrapper #66285
Merged
mixxx: drop custom wrapper #66285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented it from being wrapped automatically because it wasn't an ELF header.
10 tasks
|
Thanks for that, I made an attempt to use qtWrapperArgs, but couldn't get it to build. I'll test it later tonight. |
|
I think I can merge this now, I'm certain it will fix your issue because the wrapper contains wrapper content#! /nix/store/xfghy8ixrhz3kyy6p724iv3cxji088dx-bash-4.4-p23/bin/bash -e
export LOCALE_ARCHIVE='/nix/store/h2b4ci4c6qs5d28lgwv9lzm02jfxcpgn-glibc-locales-2.27/lib/locale/locale-archive'
export QT_PLUGIN_PATH='/nix/store/qa3faa7dy41wxd1y2ldmg5fzc3pdwb10-qtbase-5.12.0-bin/lib/qt-5.12/plugins'${QT_PLUGIN_PATH:+':'}$QT_PLUGIN_PATH
export QT_PLUGIN_PATH='/nix/store/js4fqglx52l2gb8f1ad34r8b11xj3y5w-qtsvg-5.12.0-bin/lib/qt-5.12/plugins'${QT_PLUGIN_PATH:+':'}$QT_PLUGIN_PATH
export QT_PLUGIN_PATH='/nix/store/xvifggs4vc2czi95gir0gpvm45ysin3s-qtdeclarative-5.12.0-bin/lib/qt-5.12/plugins'${QT_PLUGIN_PATH:+':'}$QT_PLUGIN_PATH
export QML2_IMPORT_PATH='/nix/store/xvifggs4vc2czi95gir0gpvm45ysin3s-qtdeclarative-5.12.0-bin/lib/qt-5.12/qml'${QML2_IMPORT_PATH:+':'}$QML2_IMPORT_PATH
export QML2_IMPORT_PATH='/nix/store/319j582m94yaar88d6qk03rgm658l26f-qtquickcontrols-5.12.0/lib/qt-5.12/qml'${QML2_IMPORT_PATH:+':'}$QML2_IMPORT_PATH
export QT_PLUGIN_PATH='/nix/store/wn784aaax0q85l5inf71ayngs14sli61-qtwayland-5.12.0-bin/lib/qt-5.12/plugins'${QT_PLUGIN_PATH:+':'}$QT_PLUGIN_PATH
export QML2_IMPORT_PATH='/nix/store/wn784aaax0q85l5inf71ayngs14sli61-qtwayland-5.12.0-bin/lib/qt-5.12/qml'${QML2_IMPORT_PATH:+':'}$QML2_IMPORT_PATH
export XDG_DATA_DIRS='/nix/store/q42dpq909szb8f3v695d585hcncnrak6-mixxx-2.2.1/share'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS
exec -a "$0" "/nix/store/q42dpq909szb8f3v695d585hcncnrak6-mixxx-2.2.1/bin/.mixxx-wrapped" "${extraFlagsArray[@]}" "$@"Which you've already verified worked for you. |
|
I think I just enough have time to build before heading out. It's compiling now, when it's done I'll report if I can start the application |
|
Yes, I can run the binary - NixOS x86_64 |
Thank you, that's very considerate of you since you should be heading out 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevented it from being wrapped
automatically because it wasn't an ELF
header.
Motivation for this change
cc @sam-willis this is actually how we have to fix this, can you test it?
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @