Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: don't bundle prebuilt docker images #66225

Merged
merged 1 commit into from Aug 8, 2019
Merged

gitlab-runner: don't bundle prebuilt docker images #66225

merged 1 commit into from Aug 8, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 6, 2019

Motivation for this change

The bundeled images are no longer compiled into the binary. They are
also not strictly required as they will be fetched if not available.

This change removes them as this reduces the closure size and also makes
updates easier.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm @max-wittig

@bachp
gitlab-runner: don't bundle prebuilt docker images
6d1958e 
The bundeled images are no longer compiled into the binary. They are
also not strictly required as they will be fetched if not available.

This change removes them as this reduces the closure size and also makes
updates easier.
@zimbatm
Copy link
Member

zimbatm commented Aug 7, 2019

The bundeled images are no longer compiled into the binary.

Does it mean that those files aren't looked up anymore by the binary?

Since the images are going to be downloaded anyways it doesn't really reduce the disk requirements on the system.

@bachp
Copy link
Member Author

bachp commented Aug 7, 2019

@zimbatm I did not verify in depth that they get loaded from the above location or not. But they get only downloaded if the docker executor is used. So it will reduce the size for everybody else.

Also neither Debian nor Archlinux ship them in their packages, so I think it's safe to remove them.

@zimbatm zimbatm merged commit 9175a20 into NixOS:master Aug 8, 2019
@zimbatm
Copy link
Member

zimbatm commented Aug 8, 2019

alright!

@bachp bachp deleted the gitlab-runner-unbundle branch August 8, 2019 17:03
@bachp bachp mentioned this pull request Aug 12, 2019
Merged
zimbatm pushed a commit that referenced this pull request Aug 12, 2019
@bachp @zimbatm
Revert "gitlab-runner: don't bundle prebuilt docker images (#66225)" (#…
f5d84bb 
…66522)

This reverts commit 9175a20.
@bachp bachp mentioned this pull request Nov 22, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @zimbatm