Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firestarter: init at 1.7.3 #66294

Merged
merged 1 commit into from Aug 17, 2019
Merged

firestarter: init at 1.7.3 #66294

merged 1 commit into from Aug 17, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented Aug 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

Thank you, just please squash your commits into one before merging this.

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

@GrahamcOfBorg build firestarter

@astro
Copy link
Contributor Author

astro commented Aug 10, 2019

Thank you, just please squash your commits into one before merging this.

Rebased and squashed.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build firestarter

@Mic92 Mic92 merged commit 2240c5c into NixOS:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants