Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv: dont try cuda on 32 bit #66292

Merged
merged 1 commit into from Aug 31, 2019
Merged

opencv: dont try cuda on 32 bit #66292

merged 1 commit into from Aug 31, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Aug 7, 2019

config.cudaSupport can be true and cudatoolkit doesn't work with i686,
which can happen inside pkgsi686Linux wrapping.

Motivation for this change

enableCuda is dependent on a global config.cudaSupport flag, but the pulled cudatoolkit only works with x86_64.
This is incompatible as a dependency via wine (defaulting to pkgsi686Linux wrapping) -> gstreamer (plugins bad) -> opencv.

This should rebuild nothing unless it's already broken, so it's probably somewhat safe.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

opencv: dont try cuda on 32 bit
62f02eb 
config.cudaSupport can be true and cudatoolkit doesn't work with i686,
which can happen inside pkgsi686Linux wrapping.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/50

@FRidh FRidh merged commit c4adedd into NixOS:master Aug 31, 2019
@averelld averelld deleted the opencv-no-cuda-on-32-bit branch August 31, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @nixos-discourse @FRidh