virtualbox: use wrapQtAppsHook #66222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @angristan testing would be appreciated 👍 |
jonringer
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
nix-review mostly passes on NixOS (I believe the packages are broken on master)
diff LGTM
[18 built (2 failed), 72 copied (2812.6 MiB), 1333.0 MiB DL]
error: build of '/nix/store/430zfb4rdb9qhlbhgbbhgsj4f5rcisk5-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66222
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.virtualbox linuxPackages_hardkernel_latest.virtualbox
2 package failed to build:
linuxPackages-libre.virtualbox linuxPackages_latest-libre.virtualbox
16 package were build:
linuxPackages.virtualbox linuxPackages_4_14.virtualbox linuxPackages_4_4.virtualbox linuxPackages_4_9.virtualbox linuxPackages_5_1.virtualbox linuxPackages_5_2.virtualbox linuxPackages_hardened.virtualbox linuxPackages_latest_hardened.virtualbox linuxPackages_latest_xen_dom0.virtualbox linuxPackages_testing_bcachefs.virtualbox linuxPackages_testing_hardened.virtualbox linuxPackages_xen_dom0.virtualbox virtualbox virtualboxHardened virtualboxHeadless virtualboxWithExtpack
angristan
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
Same results as @jonringer! Virtualbox launches correctly now.
|
@angristan How about |
|
I will try and let you know! (I have to rebuild it all) |
|
|
|
Thanks @angristan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #66200
See: #65399
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)