Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: 1.16.0 -> 1.17.1 #66269

Merged
merged 1 commit into from Aug 7, 2019
Merged

golangci-lint: 1.16.0 -> 1.17.1 #66269

merged 1 commit into from Aug 7, 2019

Conversation

johnchildren
Copy link
Contributor

@johnchildren johnchildren commented Aug 7, 2019 •
edited

Motivation for this change

Version bump for golangci-lint

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@johnchildren
golangci-lint: 1.16.0 -> 1.17.1
c805c23 
Version bump for golangci-lint
@ofborg ofborg bot requested a review from kalbasit August 7, 2019 12:06
@adisbladis
Copy link
Member

@GrahamcOfBorg build golangci-lint

@adisbladis
Copy link
Member

adisbladis commented Aug 7, 2019 •
edited

The Darwin failure is unrelated (https://hydra.nixos.org/build/98308364/nixlog/3), we can ignore it for this PR.

Thanks!

@adisbladis adisbladis merged commit c9d3169 into NixOS:master Aug 7, 2019
@johnchildren johnchildren deleted the golangci-lint-update branch August 7, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnchildren @adisbladis