Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: 4.0.0 -> 4.1.0 #66191

Merged
merged 1 commit into from Aug 13, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 6, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wolfssl/versions.

meta.description for wolfssl is: '"A small, fast, portable implementation of TLS/SSL for embedded devices"'.

meta.homepage for wolfssl is: '"https://www.wolfssl.com/"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
wolfssl

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/vigylrc7r5z7j1jjljg2pvidwxyvzqr7-wolfssl-4.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A wolfssl https://github.com/r-ryantm/nixpkgs/archive/ef8e758e6446356162de413a4fc339262c3c3bed.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vigylrc7r5z7j1jjljg2pvidwxyvzqr7-wolfssl-4.1.0
ls -la /nix/store/vigylrc7r5z7j1jjljg2pvidwxyvzqr7-wolfssl-4.1.0/bin

cc @mcmtroffaes for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/wolfssl/versions
@mmahut
Copy link
Member

mmahut commented Aug 7, 2019

I'm confused about this, as I'm getting no output packages with nix-review.

@worldofpeace
Copy link
Contributor

I bet the postInstall has something to do with it. Maybe remove the outputs to ensure that make actually installs things.

@worldofpeace
Copy link
Contributor

cc @mcmtroffaes
(they seem to be inactive for a bit, maybe mark as broken?)

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

If we do not get a reply in a week, we can mark it as broken.

@worldofpeace
Copy link
Contributor

If we do not get a reply in a week, we can mark it as broken.

Sounds fine.

@marsam
Copy link
Contributor

marsam commented Aug 10, 2019

$out is intended to be empty #16389 (comment)

@worldofpeace worldofpeace merged commit bf1cf3d into NixOS:master Aug 13, 2019
@mcmtroffaes
Copy link
Contributor

Thanks for merging, and sorry for the delay in my response. I've tested the update just now and all looks good. For the record, no package currently depends on wolfssl, so for testing I recompiled curl against wolfssl using the following shell.nix:

with import <nixpkgs> {};
let
  curlwolfssl = (curl.override {
    openssl = wolfssl;
  }).overrideDerivation (oldAttrs: {
    configureFlags =
      # --with-ca-fallback does not work with wolfssl
      (builtins.filter (x: x != "--with-ca-fallback") oldAttrs.configureFlags)
      ++ ["--with-wolfssl=${wolfssl}" "--without-ssl"];
  });
in
{
  my-env = stdenv.mkDerivation {
    name = "my-env";
    buildInputs = [
      curlwolfssl
    ];
  };
}

I tested the resulting curl binary and compared its output against my local curl binary provided by Fedora:

curl -2 https://nixos.org
curl --cacert /etc/ssl/certs/ca-bundle.crt https://nixos.org > 1.txt
/usr/bin/curl https://nixos.org > 2.txt
diff 1.txt 2.txt

The first line gives an error message "curl: (35) wolfSSL does not support SSLv2" confirming that wolfssl is indeed used. Diff of output of local curl and this new curl shows identical outputs as expected.

@r-ryantm r-ryantm deleted the auto-update/wolfssl branch August 17, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants