Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grc: leave /etc/grc.conf alone so we can override it #66248

Merged
merged 1 commit into from Aug 26, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

grc needs a config file - by default that is /etc/grc.conf but we patch that to /nix/store/....grc/etc. The problem is that we cannot then provide custom config in /etc/grc.conf, so instead patch the /usr/local/etc/grc.conf location to point to the store and leave /etc/grc.conf alone.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @AndersonTorres

@peterhoeg peterhoeg merged commit de20ba7 into NixOS:master Aug 26, 2019
@peterhoeg peterhoeg deleted the f/grc branch August 26, 2019 06:35
@peterhoeg peterhoeg restored the f/grc branch August 26, 2019 09:58
@peterhoeg peterhoeg deleted the f/grc branch August 26, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant