Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeFrameworks.ktexteditor: compile with editorconfig-core-c #66231

Merged
merged 1 commit into from Aug 7, 2019
Merged

kdeFrameworks.ktexteditor: compile with editorconfig-core-c #66231

merged 1 commit into from Aug 7, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Aug 6, 2019

Motivation for this change

Add this new dependency to ktexteditor to make it support the .editorconfig configuration format.

This should propagate the feature to the editors using this lib, namely kate, kile and kdevelop. I tested it by building kate from this branch via:

nix-env -i kate -f ~/git/nixpkgs/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel , I hope I'm not pinging you too much 🙇‍♂️

@xvello xvello requested a review from ttuegel as a code owner August 6, 2019 20:44
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build kdeFrameworks.ktexteditor

@xvello @worldofpeace
kdeFrameworks.ktexteditor: compile with editorconfig-core-c
2780e0b 
Add one small dependency to ktexteditor to make it
support the .editorconfig configuration format.
@worldofpeace worldofpeace changed the title ktexteditor: compile with editorconfig-core-c kdeFrameworks.ktexteditor: compile with editorconfig-core-c Aug 7, 2019
@worldofpeace worldofpeace merged commit fc51db8 into NixOS:master Aug 7, 2019
@worldofpeace
Copy link
Contributor

Thanks @xvello 🌸

@xvello xvello deleted the xvello/ktexteditor-editorconfig branch August 7, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xvello @worldofpeace