Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] kubernetes: 1.13.7 -> 1.13.9 #66232

Merged
merged 1 commit into from Aug 7, 2019
Merged

[19.03] kubernetes: 1.13.7 -> 1.13.9 #66232

merged 1 commit into from Aug 7, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Aug 6, 2019

Motivation for this change

CVE-2019-11247
See: kubernetes/kubernetes#80983 and https://seclists.org/oss-sec/2019/q3/117

Unstable needs 1.14.5, but I'll prefer bumping to 1.15.2. Will look into that tomorrow.

RBAC and DNS-tests run clean locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker August 6, 2019 21:10
@samueldr samueldr changed the title kubernetes: 1.13.7 -> 1.13.9 [19.03] kubernetes: 1.13.7 -> 1.13.9 Aug 7, 2019
@samueldr
Copy link
Member

samueldr commented Aug 7, 2019

Why isn't this a cherry-pick -x from master?
— inattentive maintainer

It's because kubernetes on master is from a different major revision than on 19.03! 👍 for this.

@samueldr
Copy link
Member

samueldr commented Aug 7, 2019

Hmmm, haven't been able to run the tests locally, due to unrelated to kubernetes failures in the tests. Though, I trust your testing as a maintainer :).

@samueldr samueldr merged commit 56d94c8 into NixOS:release-19.03 Aug 7, 2019
@johanot johanot deleted the CVE-2019-11247 branch August 7, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @samueldr