spotifyd: update cargoSha256 hash #66233
Conversation
When installing, the Cargo package hash is incorrect. This has been updated, and works locally.
|
Are you on a Raspberry Pi or any other AArch64? I experienced the same problem on my Raspberry Pi 3, but not on my x86_64 machine. I do not think the solution is to change the hash, because then the package will be broken on x86_64 machines. I have meant to investigate it further but have not had the time yet. Hear are some readings I had planned to check out: |
|
Hmm. I'm using a Dell XPS 13, x86_64 machine. I'm happy to send any more
debug information, and will take a look at those links. I'll also try
install it in a pure shell without other dependencies maybe?
…On Wed, 7 Aug 2019, 01:11 Anders Lundstedt, ***@***.***> wrote:
Are you on a Raspberry Pi or any other AArch64? I experienced the same
problem on my Raspberry Pi 3, but not on my x86_64 machine. I do not think
the solution is to change the hash, because then the package will be broken
on x86_64 machines. I have meant to investigate it further but have not had
the time yet. Hear are some readings I had planned to check out:
-
https://discourse.nixos.org/t/does-cargo-tooling-pick-up-wrong-crate-name-or-is-it-just-me/2769
-
#60668 <#60668>
-
#62935 <#62935>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66233?email_source=notifications&email_token=ADDZDVUIYGNWYDFBASAJFR3QDIAJRA5CNFSM4IJ2FZDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WW5EI#issuecomment-518876817>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADDZDVWDQCHVJHYB6T3NIZLQDIAJRANCNFSM4IJ2FZDA>
.
|
|
64machine
Sent from my 📲
R1/08/07 午前1:20、Benjamin <notifications@github.com>のメール:
… Hmm. I'm using a Dell XPS 13, x86_64 machine. I'm happy to send any more
debug information, and will take a look at those links. I'll also try
install it in a pure shell without other dependencies maybe?
On Wed, 7 Aug 2019, 01:11 Anders Lundstedt, ***@***.***>
wrote:
> Are you on a Raspberry Pi or any other AArch64? I experienced the same
> problem on my Raspberry Pi 3, but not on my x86_64 machine. I do not think
> the solution is to change the hash, because then the package will be broken
> on x86_64 machines. I have meant to investigate it further but have not had
> the time yet. Hear are some readings I had planned to check out:
>
> -
>
>
> https://discourse.nixos.org/t/does-cargo-tooling-pick-up-wrong-crate-name-or-is-it-just-me/2769
> -
>
> #60668 <#60668>
> -
>
> #62935 <#62935>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#66233?email_source=notifications&email_token=ADDZDVUIYGNWYDFBASAJFR3QDIAJRA5CNFSM4IJ2FZDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WW5EI#issuecomment-518876817>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADDZDVWDQCHVJHYB6T3NIZLQDIAJRANCNFSM4IJ2FZDA>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I have now investigated a bit. The The reason that the current hash worked for me is that I have backported All in all, the hash should be updated and thus this should be merged. |
|
This pull request has been mentioned on Nix community. There might be relevant details there: |
|
Great. Thanks @anderslundstedt . This was my first Nix PR, so it's been cool to see the process work! I'm sure it won't be my last. |
|
I'm more and more convinced that we need some better way to deal with fixed output derivations. Anyway, thanks for the contribution @BenSchZA and the review @anderslundstedt! |
Motivation for this change
When installing, the Cargo package hash is incorrect - this means the package fails to install. The expected hash is different from the actual
cargoSha256hash. This PR is a simple update to this hash, and has been tested and works locally.I'm playing music using
spotifydas we speak. Great package!Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @anderslundstedt