Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] pythonPackages.fipy: init at 3.3 #64643

Closed
wants to merge 7 commits into from
Closed

[WIP] pythonPackages.fipy: init at 3.3 #64643

wants to merge 7 commits into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jul 11, 2019 •
edited

Motivation for this change

Adding nist package

Things done

cc @wd15

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner July 11, 2019 22:00
@costrouc
Copy link
Member Author

costrouc commented Jul 12, 2019 •
edited

@wd15 what other packages are necessary? The build works now

  • https://github.com/ktchu/LSMLIB and the python module?
  • gmsh? I packaged pygmsh but it looks like it is a different package?
  • mpi4py?
  • tkinter?
  • trillinos and pytrilinos?

You can test this with

nix-shell -I nixpkgs=https://github.com/costrouc/nixpkgs/archive/python-fipy-init.zip -p python3Packages.fipy

@costrouc costrouc changed the title [WIP] pythonPackages.fipy: init at ... [WIP] pythonPackages.fipy: init at 3.3 Jul 12, 2019
@FRidh
Copy link
Member

FRidh commented Jul 13, 2019

looks good to me so far

@jonringer
Copy link
Contributor

you got some merge conflicts, do you mind rebasing and pushing again? :)

@costrouc
Copy link
Member Author

@jonringer happy to do that. Still waiting on nist fipy developers to state what packages they would find most useful in the image. The setup.py is a bit deceiving.

@wd15
Copy link
Contributor

wd15 commented Jul 14, 2019 via email

@wd15
Copy link
Contributor

wd15 commented Jul 14, 2019

Also, FiPy's conda-forge recipe is helpful, https://github.com/conda-forge/fipy-feedstock/blob/master/recipe/meta.yaml

This was referenced Jul 15, 2019
Closed
Merged
@wd15
Copy link
Contributor

wd15 commented Jul 23, 2019

@costrouc, you can close this now as its been replaced by #65035

@costrouc costrouc closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @FRidh @jonringer @wd15