citrix_workspace: add 1906 (citrix_workspace_19_6_0)
#64645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New release available: https://www.citrix.com/downloads/workspace-app/linux/workspace-app-for-linux-latest.html Apart from the new version the following things changed: * Updated the docs as all notes about `citrix_receiver` also apply for `citrix_workspace`. Also added a deprecation warning about the upcoming removal. * Removed the `libidn_134` override as neither `citrix_workspace_19_3_0` nor `citrix_workspace_19_6_0` require this library anymore according to `readelf -d ./result/opt/citrix-icaclient/wfica` (in contrast to `citrix_receiver_13_10_0`). * Added myself as maintainer as well.
|
cc @garry-cairns @FRidh @obadz As Citrix Receiver will be EOLed at the end of 2019 (https://www.citrix.com/support/product-lifecycle/milestones/receiver.html) we should probably drop this before 19.09. |
|
@Ma27 I am fine with that. |
|
Still get a segmentation fault unfortunately :( |
|
What do you mean with "Still"? |
|
Well, with version 19.03 I got segfaults at some point as well. I never bothered with bisecting it, primarily because with Citrix you'll never know whether it works anyway... |
|
Hmm that's pretty unfortunate as I tested the package on master and cherry-picked the commit onto my personal release-19.03 tracking branch. Is there any chance to get a minimal VM where I could reproduce this? :) |
10 tasks
obadz
added a commit
to obadz/nixpkgs
that referenced
this pull request
Sep 14, 2019
Already documented in NixOS#64645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New release available:
https://www.citrix.com/downloads/workspace-app/linux/workspace-app-for-linux-latest.html
Apart from the new version the following things changed:
Updated the docs as all notes about
citrix_receiveralso apply forcitrix_workspace. Also added a deprecation warning about theupcoming removal.
Removed the
libidn_134override as neithercitrix_workspace_19_3_0nor
citrix_workspace_19_6_0require this library anymore accordingto
readelf -d ./result/opt/citrix-icaclient/wfica(in contrast tocitrix_receiver_13_10_0).Added myself as maintainer as well.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)