Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix stdenv.xml #64620

Merged
merged 1 commit into from Jul 11, 2019
Merged

doc: fix stdenv.xml #64620

merged 1 commit into from Jul 11, 2019

Conversation

madjar
Copy link
Member

@madjar madjar commented Jul 11, 2019

Motivation for this change

A duplicated opening tag caused the linter to fail, blocking the whole
nixpkgs-unstable channel.

This change makes the manual build again, and should help unblocking nixpkgs-unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

A duplicated opening tag caused the linter to fail, blocking the whole
nixpkgs-unstable channel.
@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

@GrahamcOfBorg eval

@FRidh FRidh merged commit ab3e932 into NixOS:master Jul 11, 2019
@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants