Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dhcpcd: Before network-online.target #64621

Merged
merged 1 commit into from Jul 12, 2019

Conversation

gloaming
Copy link
Contributor

Motivation for this change

Long overdue!
Fixes #60900. See also #61098

Things done

I ran the following NixOS tests:

nixos/tests/networking.nix
nixos/tests/predictable-interface-names.nix
nixos/tests/cloud-init.nix

They seem to be OK, but the output doesn't actually say "fail" or "success".

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @flokli @worldofpeace

Instead of network.target. Fixes NixOS#60900 (delayed boot).
@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Jul 11, 2019

Should we make cloud-init depending on network-online.target as well? 48f7778

@gloaming
Copy link
Contributor Author

@Mic92 that was already done back then, #44633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow boot due to dhcpcd (tracking issue)
4 participants