Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deluge: 1.1.11 -> 2.0.3 #64542

Closed
wants to merge 3 commits into from
Closed

deluge: 1.1.11 -> 2.0.3 #64542

wants to merge 3 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 9, 2019

Motivation for this change

Requires libtorrentrasterbar update, will link relevant PR's shortly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
libtorrent-rasterbar: 1.1.11 -> 1.2.1
b53fd36 
https://github.com/arvidn/libtorrent/releases/tag/libtorrent-1_2_1
https://github.com/arvidn/libtorrent/releases/tag/libtorrent_1_2_0
https://github.com/arvidn/libtorrent/releases/tag/libtorrent-1_1_13
https://github.com/arvidn/libtorrent/releases/tag/libtorrent_1_1_12
@dtzWill
deluge: 1.3.15 -> 2.0.3
11d8ec9 
* let's try 2.0 version now, no time better than the present! Maybe!
* bz2 -> xz
* maybe python3
* disable pyGtkGlade for deps, maybe not needed?
* fix gtk/etc deps, deluge-gtk works! \o/
* restore installation of images and such
@dtzWill dtzWill mentioned this pull request Jul 9, 2019
Closed
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Jul 9, 2019

#64496 for dependency bump, cc'ing recent deluge PR's that we might want to coordinate /test together, or even just encourage seeing these all through! :)

#64112 .. i thought there was at least one other, teehee.

@dtzWill dtzWill mentioned this pull request Jul 9, 2019
Closed
@ofborg ofborg bot requested review from Phreedom and domenkozar July 9, 2019 23:01
@dtzWill
Copy link
Member Author

dtzWill commented Jul 9, 2019

@GrahamcOfBorg build deluge
@GrahamcOfBorg test deluge

(I'm unsure if the test currently passes or is obviously going to fail due to changes across major version, but let's find out! ^_^)

FRidh
FRidh reviewed Jul 10, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -2464,7 +2464,8 @@ in
ddrutility = callPackage ../tools/system/ddrutility { };

deluge = callPackage ../applications/networking/p2p/deluge {
pythonPackages = python2Packages;
pythonPackages = python3Packages;
libtorrentRasterbar = libtorrentRasterbar.override { python = python3; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to perform this override inside the deluge expression to ensure the same python is always used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this package is already overridden in python-packages.nix!

@ghost
Copy link

ghost commented Jul 22, 2019

Thanks a lot! Quite a few of the trackers I'm using haven't whitelisted the new version yet and probably won't do so very soon because of the big changes it introduces. I would propose having deluge and deluge2 coexist for some time until it is accepted by most trackers.

@infinisil
Copy link
Member

Yeah agreed with @petabyteboy

I also just heard that Deluge 2 apparently performs auto-migration of its state, so you can't easily downgrade again. So this should definitely be separate from v1 for a while

Ping @bricewge for maybe some help with getting the NixOS module to work

@infinisil infinisil mentioned this pull request Aug 31, 2019
Closed
10 tasks
@peterhoeg
Copy link
Member

Quite a few of the trackers I'm using haven't whitelisted the new version yet

This might be off-topic, but do you know how that happens @petabyteboy? Is it similar to the user-agent in a browser or is there something else going on?

@peterhoeg
Copy link
Member

@dtzWill, please note that the upgrade breaks the nixos module.

@ghost
Copy link

ghost commented Sep 4, 2019

Quite a few of the trackers I'm using haven't whitelisted the new version yet

This might be off-topic, but do you know how that happens @petabyteboy? Is it similar to the user-agent in a browser or is there something else going on?

Yes, the client sends a 20 byte peer id containing implementation and version information: http://www.bittorrent.org/beps/bep_0020.html

@mweinelt
Copy link
Member

mweinelt commented Oct 28, 2019 •
edited

Hey, I just found it and needed to test (the thin client part of) it. So the GTK client works, but it is missing icons everywhere.

This is what happens at startup:

(deluge:22236): Gtk-WARNING **: 23:38:11.963: Could not find the icon 'list-remove-symbolic-ltr'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
	http://icon-theme.freedesktop.org/releases

I then added hicolor-icon-theme to propagated build inputs, that got rid of the error message, but icons are still missing, primarily the ones on the toolbar.

@evanjs
Copy link
Member

evanjs commented Jan 15, 2020

Icons seems to appear fine outside of a nix-shell, presumably because hicolor-icons-theme is in my systemPackages, but within a nix-shell, many of the icons are indeed missing. I am not seeing any warning messages, though.

Additionally, this behavior does not seem to be uncommon among GTK apps, so I wonder if somebody with more experience in this realm has some thoughts on the matter.

@Soundtoxin
Copy link

Any news on this? I would love to be able to update soon!

@ghost
Copy link

ghost commented Jan 15, 2020

I would also like to update, but I would need to be able to run 1.x and 2.x in parallel because my trackers still haven't whitelisted it sigh.
I will prepare a PR to make that possible.

@ghost ghost mentioned this pull request Jan 15, 2020
Merged
10 tasks
@infinisil
Copy link
Member

To be superseded by above PR

@infinisil infinisil closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@Phreedom Phreedom Awaiting requested review from Phreedom

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtzWill @infinisil @peterhoeg @mweinelt @evanjs @Soundtoxin @FRidh