Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ahem.css in css-grid tests. #17743

Merged
merged 3 commits into from Jul 19, 2019

Conversation

LukeZielinski
Copy link
Contributor

@LukeZielinski LukeZielinski commented Jul 9, 2019

This is part of the transition to using Ahem as a web font. These tests were broken by this transition but seem to work now.

Carving these tests out from #17205 for individual review.

@LukeZielinski
Copy link
Contributor Author

@foolip Looks like the css-grid tests benefited from reftest-wait, even if we don't do a delayed screenshot. Can these be submitted like this?

@foolip
Copy link
Member

foolip commented Jul 9, 2019

@LukeZielinski looks like the test are timing out now because the reftest-wait class is never removed. That makes them pass the stability check, but it's still breaking the tests. Oops :)

@LukeZielinski
Copy link
Contributor Author

@LukeZielinski looks like the test are timing out now because the reftest-wait class is never removed. That makes them pass the stability check, but it's still breaking the tests. Oops :)

Doh! didn't click enough buttons. Abandoning.

@LukeZielinski LukeZielinski deleted the ahem-css-grid branch July 10, 2019 02:08
@LukeZielinski LukeZielinski restored the ahem-css-grid branch July 15, 2019 14:51
@LukeZielinski LukeZielinski reopened this Jul 15, 2019
@LukeZielinski
Copy link
Contributor Author

@LukeZielinski looks like the test are timing out now because the reftest-wait class is never removed. That makes them pass the stability check, but it's still breaking the tests. Oops :)

Doh! didn't click enough buttons. Abandoning.

..Actually, I realize I just needed to takeScreenshot call - so it looks like this passes if we do takeScrenshot (without the delay)?

@LukeZielinski LukeZielinski assigned foolip and unassigned tabatkins Jul 18, 2019
@LukeZielinski
Copy link
Contributor Author

So the latest on this is that these tests do seem to pass by simply loading ahem stylesheet, without any explicit waiting or screenshotting. @foolip WDYT?

@LukeZielinski LukeZielinski changed the title Add reftest-wait and ahem.css to css-grid tests. Use ahem.css in css-grid tests. Jul 18, 2019
@foolip
Copy link
Member

foolip commented Jul 18, 2019

Well that's pretty funny, wasn't that the original change carved out from #17205?

When we were debugging this a Chrome bug seemed somewhat plausible, so maybe Chrome actually changed and that's why it's now passing.

@LukeZielinski is this a case you were ever able to repro locally by opening the test in a browser manually? If so could you use https://www.chromium.org/developers/bisect-builds-py to verify that the change is due to a Chromium change? If not, then I say let's just merge this since it passes :)

@LukeZielinski
Copy link
Contributor Author

LukeZielinski commented Jul 19, 2019

@LukeZielinski is this a case you were ever able to repro locally by opening the test in a browser manually? If so could you use https://www.chromium.org/developers/bisect-builds-py to verify that the change is due to a Chromium change? If not, then I say let's just merge this since it passes :)

This is one of the test that behaves differently locally than on CI unfortunately, so I'm inclined to just submit.

@LukeZielinski LukeZielinski merged commit a1aa04f into web-platform-tests:master Jul 19, 2019
@LukeZielinski LukeZielinski deleted the ahem-css-grid branch July 19, 2019 14:44
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
* Add ahem.css to css-grid tests that regressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants