@worldofpeace: Hello, as you're the one who have merged the last gocryptfs update,
I kindly ask if you wanna have a look on my PR.

@GrahamcOfBorg build gocryptfs

@GrahamcOfBorg build gocryptfs

building again for darwin

I'm generating a different deps.nix locally.

The process I've done to do this was

1. checkout `gocryptfs` repo locally

2. `$ git checkout v1.7`

3. `$ dep2nix`

Here's a gist of the diff

Additionally the build fails on darwin.
This patch upstream should fix this rfjakob/gocryptfs@b1468a7 (please use fetchpatch in patches)

Thx.

About the deps.nix I did it on the latest commit (forgot checking out v1.7).

And I'm not sure if the thing with the patches I did now is right?

@GrahamcOfBorg build gocryptfs

@GrahamcOfBorg build gocryptfs

I'm exited. There was a lot I've learned until now in this little update.
@worldofpeace: Thank you very much for your assistance.

I'm exited. There was a lot I've learned until now in this little update.
@worldofpeace: Thank you very much for your assistance.

I'm glad you're excited. It's a secret that most nixpkgs reviewers are little mentors 😄

In the push I fixed a little tricky thing where we have to manually update the sys module
to have that fix, since the bug came from there too.

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/33

@cw789 I can merge this it just needs to be squashed into one commit

@cw789 I think the best way to deal with "on next update do xyz" type of comments is to put them on the version line. People are unlikely to read all comments in a file on every update, but its hard to miss the one one the version line. Even if the updater misses it, it will show up in the diff for the reviewer.

Doesn't matter in this case, since the patch will fail to apply on update anyway. Just general advice for the future.

@timokau: Thank you, for this advice.

@worldofpeace: I think I've made it.

@cw789 Thanks for doing this ✨