Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtutilities: init at 5.13.0 #64570

Merged
merged 1 commit into from Jul 17, 2019
Merged

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) - not applicable.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

@doronbehar #64570 (comment) Wasn't resolved.

@doronbehar
Copy link
Contributor Author

Oh I guess I solved only the first issue - where I've had the callPackage called twice. Is it crucial to have qtutilities both defined under the libsForQt${version} attributes and both in the root level attribute? I won't mind adding that as you wish but I'd like to understand. It's just that this part of the manual says this should be done only for applications and this is a library.

@worldofpeace
Copy link
Contributor

@doronbehar Ahh, it should just be called under the mkLibsForQt5 = self: with self; { since it's just a qt library.

@worldofpeace
Copy link
Contributor

Didn't notice that till now since reviewing all-packages.nix is simply impossible if not done locally.

@doronbehar
Copy link
Contributor Author

@worldofpeace could you please tell @GrahamcOfBorg build libsForQt5.qtutilities? I think all of the issues discussed above are resolved now. Thanks.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM builds locally.

@doronbehar
Copy link
Contributor Author

Thanks!

@doronbehar doronbehar deleted the package-qtutilities branch July 17, 2019 16:09
@doronbehar doronbehar mentioned this pull request Aug 24, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants