pythonPackages.sphinxcontrib_plantuml: use top-level plantuml #64625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. One remark, please adjust the commit message according to the guidelines. In this case I suggest something like:
|
roman-kashitsyn
changed the title
plantuml declared in python packages implicitly captures graphviz python library instead of the top-level package and thus doesn't work property after installation, trying to access /nix/store/<hash>-python2.7-graphviz-0.10.1/bin/dot and failing to find it.
|
Done. Thanks for a quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
plantumldeclared in python packages implicitly captures graphviz python library instead of the top-level package and thus doesn't work property after installation, trying to access/nix/store/<hash>-python2.7-graphviz-0.10.1/bin/dotand failing to find it.