Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2-cutter: 1.8.0 -> 1.8.3 #64626

Merged
merged 1 commit into from Jul 13, 2019
Merged

radare2-cutter: 1.8.0 -> 1.8.3 #64626

merged 1 commit into from Jul 13, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 11, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jul 11, 2019

cc @dtzWill

@ofborg ofborg bot requested review from 7c6f434c and dtzWill July 11, 2019 13:44
teto
teto reviewed Jul 11, 2019
View reviewed changes
pkgs/development/tools/analysis/radare2/cutter.nix Outdated
@@ -8,7 +8,7 @@
, python3 }:

let
version = "1.8.0";
version = "1.8.3";
in
stdenv.mkDerivation rec {
name = "radare2-cutter-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname 👍 :p

@FRidh FRidh merged commit 7b67364 into NixOS:master Jul 13, 2019
@Mic92 Mic92 deleted the cutter branch July 17, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @teto @FRidh