pythonPackages.django-logentry-admin: init at 1.0.4 #64579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaito
approved these changes
Jul 10, 2019
jonringer
reviewed
Jul 10, 2019
| # too complicated to setup, requires a running django instance | ||
| doCheck = false; | ||
|
|
||
| # checkInputs = [ tox ]; |
There was a problem hiding this comment.
i would just remove this if it's relevant.
Suggested change
| # checkInputs = [ tox ]; |
risicle
reviewed
Jul 10, 2019
| }; | ||
|
|
||
| # too complicated to setup, requires a running django instance | ||
| doCheck = false; |
There was a problem hiding this comment.
src = fetchFromGitHub {
owner = "yprez";
repo = pname;
rev = "v${version}";
sha256 = "1ji04qklzhjb7fx6644vzikjb2196rxyi8hrwf2knsz41ndvq1l9";
};
checkInputs = [ pytest pytest-django ];
checkPhase = ''
rm -r logentry_admin __init__.py
pytest
'';
There was a problem hiding this comment.
oh... wow :)
not so complicated, after all
MrMebelMan
force-pushed
the
init/django-logentry-admin
branch
from
9a7408b
to
1914911
Compare
|
@GrahamcOfBorg build pythonPackages.django-logentry-admin python3Packages.django-logentry-admin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)