Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.dsl: Add optional name_suffix to Resource.family. #146

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

cr1901
Copy link
Contributor

@cr1901 cr1901 commented Jul 10, 2019

Just as Resource.family makes it easier to generate Resources with a fallback name, this PR makes it easier to support Resources in nmigen_boards that only differ in features and should have identical prefixes names, such as SPI flashes with different widths.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #146 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   80.67%   80.67%   +<.01%     
==========================================
  Files          32       32              
  Lines        5215     5217       +2     
  Branches     1128     1129       +1     
==========================================
+ Hits         4207     4209       +2     
  Misses        873      873              
  Partials      135      135
Impacted Files Coverage Δ
nmigen/build/dsl.py 94.83% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278b624...b1f7347. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants