Add action option string to be passed to toast showToast() #17774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1684466
branch
from
32548e8
to
4c734b2
Compare
This partially implements the action option for showToast(), as outlined in the explainer at https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options. For now it only handles the string or undefined cases; the Element case will be handled in a follow-up CL once the action setter is implemented. BUG=972945 Change-Id: I82556801a6586c89cd506669f935488e049c47c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676168}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1684466
branch
from
4c734b2
to
24e5086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially implements the action option for showToast(),
as outlined in the explainer at
https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options.
For now it only handles the string or undefined cases;
the Element case will be handled in a follow-up CL once the action setter is implemented.
BUG=972945
Change-Id: I82556801a6586c89cd506669f935488e049c47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676168}