Change height and width of set.py tests to be larger than min for chrome #17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
andreastt
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
You should probably also be aware of https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/support/defaults.py#6.
|
@julianrkung, have you seen the last comment from @andreastt? Do we have another PR for that yet? |
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome's webdriver was failing test_width_height_floats, test_restore_from_minimized, and test_restore_from_maximized because the proposed width change (<=500 pixels) was smaller than chrome's set minimum browser size. Changed all such values in the above tests (both height and width as a precaution) to more moderate values that shouldn't conflict with minimum or maximum browser size for any browser.