[UserTimingL3] Fix crash: create mark in worker #17773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1696085
branch
3 times, most recently
from
35f93bb
to
f3fc388
Compare
Currently, the renderer crashes when creating mark entry in worker. The crash is because PerformanceMark::Create() return nullptr without setting exception_state. The caller of the function assumes that no exception indicates the PerformanceMark entry exists. Thus, when the entry is visited, the crash occurs. There is another bug hidden in this issue. Currently, when window-performance is not found, Create() returns nullptr directly. It should instead also check whether worker-performance exist. This CL fix these issues. To verify the change, the CL also changes the related web tests from *.html to *.any.js, which enables these tests in worker's context. Bug: 981982 Change-Id: Ia20ce1c194e4db2810ff3f1c52070e5970951600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696085 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676484}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1696085
branch
from
f3fc388
to
cd05ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the renderer crashes when creating mark entry in worker.
The crash is because PerformanceMark::Create() return nullptr without
setting exception_state. The caller of the function assumes that
no exception indicates the PerformanceMark entry exists. Thus, when the
entry is visited, the crash occurs.
There is another bug hidden in this issue. Currently, when
window-performance is not found, Create() returns nullptr directly. It
should instead also check whether worker-performance exist.
This CL fix these issues.
To verify the change, the CL also changes the related web tests from
*.html to *.any.js, which enables these tests in worker's context.
Bug: 981982
Change-Id: Ia20ce1c194e4db2810ff3f1c52070e5970951600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696085
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676484}