Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overmind: 2.0.1 -> 2.0.2 #64600

Merged
merged 1 commit into from Jul 11, 2019
Merged

overmind: 2.0.1 -> 2.0.2 #64600

merged 1 commit into from Jul 11, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 10, 2019

Motivation for this change

Update overmind to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build overmind

@adisbladis
Copy link
Member

adisbladis commented Jul 10, 2019 •
edited

Hmm... Personally I'm not a fan of buildGoModule as it abuses fixed-output derivations..
I think I'll run vgo2nix on this instead.

See NixOS/nix#2270

@ofborg ofborg bot requested review from kalbasit and adisbladis July 10, 2019 19:29
@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 11, 2019

Hi, @adisbladis. Thanks for the review!
pkgs/applications/misc/overmind/default.nix reverted back to buildGoPackage.

worldofpeace
worldofpeace approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes, changes looked minimal.

@worldofpeace worldofpeace merged commit 528a690 into NixOS:master Jul 11, 2019
@xrelkd xrelkd deleted the update/overmind branch July 11, 2019 13:16
@adisbladis
Copy link
Member

@xrelkd Thanks! Upstream is vendoring all dependencies anyway so buildGoModule brought nothing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @adisbladis @worldofpeace