Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monoid: 2016-07-21 -> 0.61 #64556

Closed
wants to merge 1 commit into from
Closed

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Fixing another "problematic" repology package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

it's big
$ nix path-info -Sh ./result
/nix/store/s8xn788iwlmsiibcjrja5kx16s71gp09-monoid-2016-07-21 430.7M
$ nix path-info -Sh ./result
/nix/store/y7xgxx35vzawaszjnx2alvcmvrj510qn-monoid-0.61 429.9M

@jonringer
Copy link
Contributor Author

$ nix-review pr 64556 passes on nixos

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64556
1 package were build:
monoid

Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that some fixes will be lost by going back to the latest released version. But I am not currently using this font.

Considering that almost every other Linux distribution is using the released version, it may make sense to use it in nixpkgs too.

@jonringer
Copy link
Contributor Author

The 3 commits from the previous release all seem to be around the readme changing supported platforms and other information. Not really changes to the font itself.

@romildo
Copy link
Contributor

romildo commented Jul 15, 2019

Comparison between version 0.61 (from Aug 11, 2015) and revision currently in nixpkgs (from Jul 21, 2016): larsenwork/monoid@0.61...e9d77ec

Some fixes will me missed with this PR.

@jonringer
Copy link
Contributor Author

oh sorry, i thought .61 was released in 2016, not 2015. Very fair point. Hmm, not sure what to do in this case then. Going to close as I think in the best case this will cause a regression since some bug fixes are a part of the current package.

@jonringer jonringer closed this Jul 15, 2019
@jonringer jonringer deleted the bump-monoid branch December 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants