Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.dockerfile-language-server-nodejs: init at 0.0.21 #64545

Merged
merged 1 commit into from Sep 24, 2019
Merged

nodePackages.dockerfile-language-server-nodejs: init at 0.0.21 #64545

merged 1 commit into from Sep 24, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build nodePackages.dockerfile-language-server-nodejs

@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch 2 times, most recently from 2cb34c8 to 305d4f2 Compare July 15, 2019 00:53
@rvolosatovs
Copy link
Member Author

Rebasing this is quite a pain - what can I do to get this merged faster?

@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch from 305d4f2 to d2ff47d Compare August 18, 2019 23:12
@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch from d2ff47d to f65c650 Compare August 27, 2019 14:15
@rvolosatovs
Copy link
Member Author

cc @cillianderoiste @gilligan @cko (nodejs maintainers)

@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch from f65c650 to b4ff604 Compare September 9, 2019 18:51
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch 2 times, most recently from a65054f to f7245a9 Compare September 12, 2019 15:24
@rvolosatovs rvolosatovs force-pushed the init/dockerfile-language-server-nodejs branch from f7245a9 to 6e7742c Compare September 23, 2019 10:09
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build nodePackages.dockerfile-language-server-nodejs

@Mic92 Mic92 merged commit 64fa932 into NixOS:master Sep 24, 2019
@rvolosatovs rvolosatovs deleted the init/dockerfile-language-server-nodejs branch September 24, 2019 09:04
@dotlambda dotlambda mentioned this pull request Aug 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @Mic92 @lheckemann