victor-mono: init at 1.2.1 #64544
Closed
victor-mono: init at 1.2.1 #64544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jul 9, 2019
| in fetchzip rec { | ||
| name = "victor-mono-${version}"; | ||
|
|
||
| url = "https://github.com/rubjo/victor-mono/archive/v1.2.1.zip"; |
There was a problem hiding this comment.
be easier to update
Suggested change
| url = "https://github.com/rubjo/victor-mono/archive/v1.2.1.zip"; | |
| url = "https://github.com/rubjo/victor-mono/archive/v${version}.zip"; |
(thanks reviewer!)
|
It seems I've merged the competing PR, seems that this one installed Too late though. |
|
Yes, is there a reason to prefer one over the other?
Or to "only" include one, if upstream provides both? (space?)
Never sure which way to go with these :).
…---
Oh, I see--I'll take a look and maybe submit a PR with the difference
:).
On Sat, 13 Jul 2019 09:07:24 -0700, worldofpeace ***@***.***> wrote:
It seems I've merged the competing PR, seems that this one installed `.otf` too.
Too late though.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#64544 (comment) part: text/html
|
|
I'd distribute both. |
|
Updated, hopefully "best of both"? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #64465.
Haven't tested installation but inspecting output LGTM-- requester want
to confirm this works for you? :)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)